Loomio
Sat 19 Jul 2014 4:11AM

Remove the admin folder from framework

S Simon Public Seen by 46

One of the goals of the 3.x series is to decouple the CMS from the framework. However, the majority of the actual CMS is still inside framework through the framework/admin folder.

I believe that this should be removed and either turned into a separate module (if it is still desired to have a smaller CMS available for framework-only projects) or to be bundled into the CMS module.

DH

Daniel Hensby
Abstain
Mon 21 Jul 2014 12:37PM

Seems sensible, but I'm not sure why it'd have to wait until vendor/ support

NJB

Nathan J. Brauer
Agree
Tue 22 Jul 2014 3:46AM

Just remember: Documentation will be needed which clearly explains when to use what and why X, Y, & Z isn't working anymore (for those upgrading).

CF

Cam Findlay
Abstain
Tue 22 Jul 2014 10:22PM

I'm unsure of the implications of this, would like to know more but happy for the group to come to a decision on this.

Z

Zauberfisch Sun 20 Jul 2014 11:18PM

I fully agree with that proposal. Do we want to take it a step further and already discuss making the framework a component based system?
(Obviously not going to implemented soon, but we can set it as a goal for the future)

SM

Sam Minnée Sun 20 Jul 2014 11:22PM

@zauberfisch although I agree with that proposal, I don't think there's a lot of value discussing it until after modules live in vendor/

Z

Zauberfisch Sun 20 Jul 2014 11:28PM

good point.
btw, my question from earlier about moving modules to vendor/ is still unanswered:

What’s actually the status on that? I remember there was a lot of work done on it during the google summer of code, but it kind of went quiet and I haven’t heard anything since.

FC

Fred Condo Mon 21 Jul 2014 5:22PM

I'm in general agreement with this, although not with the version of it that involves bundling all of admin into the CMS. We don't always want SiteTree, so admin & cms really should stay separate.

Inasmuch as this doesn't seem to imply any large API changes such as we had between 3.0 & 3.1, I lean towards this being a 3.2 change.

Z

Zauberfisch Thu 24 Jul 2014 10:49PM

@fredcondo no, it will be an additional module. so you have CMS, Admin and Framework. CMS requires Admin, and Admin requires Framework.
If you just want an Admin for ModelAdmin / LeftAndMain, but no SiteTree, simply only install Admin + Framework and not CMS

Z

Zauberfisch Thu 24 Jul 2014 10:53PM

@camfindlay1 I can't really think of any major api change through this.
As a first step I think we will simply move all admin stuff into a new module. and CMS will have this new module as dependency, so everyone using composer will automatically get this module anyway.
And people not using composer will just download the zip from the website and see that there now is 1 more module/folder.

The only issue I could think of is if people use hardcoded links to css/js files inside framework, but those people need to be punished anyway :P

One thing that will change things is moving modules into the vendor/ folder, but I think that's to be discussed in another thread.